feat(helm): support for specifying flag on region, #646
Open
johnksv wants to merge 2 commits intoInseeFrLab:mainfrom
Open
feat(helm): support for specifying flag on region, #646johnksv wants to merge 2 commits intoInseeFrLab:mainfrom
johnksv wants to merge 2 commits intoInseeFrLab:mainfrom
Conversation
…start with The implementation allows one to easily add helm flags on the region - which will then be used during helm upgrade (i.e. install, suspend, resume). The reason to add it on the region is that these flags make sense for all services rather then on a catalog or service level (these kind of flags manipulate how helm functions, and we want the same result for all services, at least as of now).
forceConflicts requires that upgrade is done server side. Thus we want the ability to supply this flag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the
force-conflictsflag to start with. This is because of the breaking change in helm 3 -> helm 4, where helm 4 will fail without this flag when a field is managed by another entity then helm.The implementation allows one to easily add helm flags on the region - which will then be used during helm upgrade (i.e. install, suspend, resume). The reason to add it on the region is that these flags make sense for all services rather then on a catalog or service level (these kind of flags manipulate how helm functions, and we want the same result for all services, at least as of now).